Skip to content

Conversation

@teocns
Copy link
Contributor

@teocns teocns commented Mar 14, 2025

Develop on dev and regular/squash merge INTO 0.4.4

Rebase and Merge 0.4.4 to main

Changelog

Tests

  • Implements tests/unit/test_session_legacy.py to verify full backwards compatibility with CrewAI's and other libs
  • Removes deprecated failing tests:
    • test_insturmentation.py
    • test_instrumentation_errors.py
    • test_core.py
  • Favors test_decorators.py
  • Adds an implementation of crew AI testing in test/unit/test_session_legacy.py

Notes

  • Type-checking errors are superficial. These can be resolved later in a different PR as it concerns developers more than the users. We might need to tweak the existing config to include more robust checks
% uv run mypy agentops
Bytecode compiled 18506 files in 786ms
agentops/helpers/system.py:7: error: Library stubs not installed for "psutil"  [import-untyped]
agentops/helpers/system.py:7: note: Hint: "python3 -m pip install types-psutil"
agentops/helpers/system.py:7: note: (or run "mypy --install-types" to install all missing stub packages)
agentops/helpers/system.py:7: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
agentops/sdk/decorators/factory.py:6: error: Skipping analyzing "wrapt": module is installed, but missing library stubs or py.typed marker  [import-untyped]
Found 2 errors in 2 files (checked 50 source files)
  • Refactored Agents SDK is a WIP and will be handled in a later release
  • 90% test coverage to also be handled in the next release

Signed-off-by: Teo <[email protected]>
@teocns teocns enabled auto-merge (squash) March 14, 2025 23:50
@teocns teocns marked this pull request as draft March 15, 2025 17:16
auto-merge was automatically disabled March 15, 2025 17:16

Pull request was converted to draft

@teocns teocns requested review from dot-agi and tcdent March 15, 2025 17:17
Copy link
Member

@dot-agi dot-agi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change required.

@dot-agi
Copy link
Member

dot-agi commented Mar 15, 2025

Testing is required with crewAI.

@teocns teocns changed the title pyproject.toml: bump 0.4.4 0.4.4 Mar 15, 2025
teocns and others added 6 commits March 15, 2025 19:29
* show session url on init

* fix: pass tags to start_session when auto-starting sessions

Co-Authored-By: Constantin-Doru Teodorescu <[email protected]>

* backwards compat: track_agent, end_all_sessions (#847)

Signed-off-by: Teo <[email protected]>

* Client.init() | auto_start_session | forward tags

Signed-off-by: Teo <[email protected]>

* client: recreate Config on init()

Signed-off-by: Teo <[email protected]>

* mock_req: /v3/auth/token to return { project_id, token, api_key }

Signed-off-by: Teo <[email protected]>

* cleanup dirty files

Signed-off-by: Teo <[email protected]>

* Isolate telemetry setup (`setup_telemetry`)

Signed-off-by: Teo <[email protected]>

* core shutdown: remove redundant initialized check

Signed-off-by: Teo <[email protected]>

* Simplify core shutdown (flush SynchronousSpanProcessor instead of iterating processors)

Signed-off-by: Teo <[email protected]>

* Improved TracingCore Config

Signed-off-by: Teo <[email protected]>

* tests: couple instrumentation tester with TracingCore's lifecycle

Signed-off-by: Teo <[email protected]>

* Base for test_session_legacy

Signed-off-by: Teo <[email protected]>

* uv lock

Signed-off-by: Teo <[email protected]>

* tests/benchmark/benchmark_init.py

Signed-off-by: Teo <[email protected]>

* Remove deprecated SDK tests - favor test_decorators

Signed-off-by: Teo <[email protected]>

* update `openai` dep and `uv.lock` file

* fix: pass tags to start_session when auto-starting sessions

Co-Authored-By: Constantin-Doru Teodorescu <[email protected]>

* forgot `{` in `start_session`

* remove `getattr`

* fix for recursion and passing `default_tags`

* client: recreate Config on init()

Signed-off-by: Teo <[email protected]>

* cleanup dirty files

Signed-off-by: Teo <[email protected]>

* Simplify core shutdown (flush SynchronousSpanProcessor instead of iterating processors)

Signed-off-by: Teo <[email protected]>

---------

Signed-off-by: Teo <[email protected]>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Constantin-Doru Teodorescu <[email protected]>
Co-authored-by: teocns <[email protected]>
Co-authored-by: Teo <[email protected]>
@codecov
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

Attention: Patch coverage is 68.61314% with 43 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/sdk/core.py 46.66% 16 Missing ⚠️
agentops/legacy/__init__.py 80.28% 14 Missing ⚠️
agentops/config.py 36.36% 7 Missing ⚠️
agentops/legacy/event.py 0.00% 3 Missing ⚠️
agentops/logging/config.py 75.00% 2 Missing ⚠️
agentops/client/client.py 83.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dot-agi dot-agi marked this pull request as ready for review March 16, 2025 22:55
Copy link
Member

@dot-agi dot-agi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️❤️

@teocns teocns merged commit c9faca8 into main Mar 17, 2025
8 of 10 checks passed
@teocns teocns deleted the 0.4.4 branch March 17, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

URL doesn't print in terminal when running with only agentops.init Error in CLI output using CrewAI

4 participants